-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#6641] fix(core): Possible error in the equals method for collection #6644
Conversation
@sunxiaojian , Can you please check all places in the project and fix them all, these two places are just examples. |
ok, I checked. I'll double-check again. |
At least |
7cbdab7
to
02c1614
Compare
fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jerqi Would you like to take a look? |
Actually I think this is weird that |
@jerqi Then let's replace it
|
@sunxiaojian could you help to check if this issue can solve the https://github.com/apache/gravitino/pull/6455/files#r1955682884 by the way? |
@yuqi1129 Solved it, I removed this code. |
5636b1b
to
9edbc5f
Compare
@sunxiaojian |
What changes were proposed in this pull request?
Possible error in the equals method for collection
Why are the changes needed?
Fix: #6641
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
N/A